Re: [PATCH v3] staging: android: Replace strcpy with strlcpy

From: Greg KH
Date: Sun Mar 12 2017 - 09:35:48 EST


On Sun, Mar 12, 2017 at 03:32:44AM +0530, simran singhal wrote:
> Replace strcpy with strlcpy as strcpy does not check for buffer
> overflow.

Can there be a buffer overflow here? If not, then strcpy is just fine
to use. Do you see a potential code path here that actually is a
problem using this?

> This is found using Flawfinder.

You mean 'grep'? :)

If not, what exactly does "Flawfinder" point out is wrong with the code
here? At first glance, I can't find it, but perhaps the tool, and your
audit, provided more information?

thanks,

greg k-h