Re: [PATCH 1/3] ata: add Palmchip BK3710 PATA controller driver

[Sergei Shtylyov]

On 03/12/2017 08:28 PM, Sergei Shtylyov wrote:

> > +static void pata_bk3710_set_piomode(struct ata_port *ap,
> > +                    struct ata_device *adev)
> > +{
> > +    void __iomem *base = (void __iomem *)ap->ioaddr.bmdma_addr;
> > +    struct ata_device *pair = ata_dev_pair(adev);
> > +    const struct ata_timing *t = ata_timing_find_mode(adev->pio_mode);
> > +    const u16 *id = adev->id;
> > +    unsigned int cycle_time;
> > +    int is_slave = adev->devno;
> > +    const u8 pio = adev->pio_mode - XFER_PIO_0;
> > +
> > +    if (id[ATA_ID_FIELD_VALID] & 2) {
> > +        if (ata_id_has_iordy(id))
> > +            cycle_time = id[ATA_ID_EIDE_PIO_IORDY];
> > +        else
> > +            cycle_time = id[ATA_ID_EIDE_PIO];
> > +
> > +        /* conservative "downgrade" for all pre-ATA2 drives */
> > +        if (pio < 3 && cycle_time < t->cycle)
> > +            cycle_time = 0; /* use standard timing */
> > +    }
> > +
> > +    if (!cycle_time)
> > +        cycle_time = t->cycle;
>
>    This seems like a helper needed by libata in general but OK...

   No, the build bot had already reported the problem with 'cycle_time' here, 
I just forgot about it.

[...]
>    Well, no serious issues found, so you can stamp:
>
> Acked-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>

   Too early, it seems... :-)

MBR, Sergei