Re: [PATCH 1/7] regulator: max1586: Constify regulator_ops

[Chanwoo Choi]

Dear all,

All patches in this series looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

Best Regards,
Chanwoo Choi

On 2017ë 03ì 12ì 04:01, Krzysztof Kozlowski wrote:
> Static struct regulator_ops is not modified so can be made const for
> code safeness.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
>  drivers/regulator/max1586.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/max1586.c b/drivers/regulator/max1586.c
> index 2c1228d5796a..6779c2b53674 100644
> --- a/drivers/regulator/max1586.c
> +++ b/drivers/regulator/max1586.c
> @@ -126,14 +126,14 @@ static int max1586_v6_set_voltage_sel(struct regulator_dev *rdev,
>   * The Maxim 1586 controls V3 and V6 voltages, but offers no way of reading back
>   * the set up value.
>   */
> -static struct regulator_ops max1586_v3_ops = {
> +static const struct regulator_ops max1586_v3_ops = {
>  	.get_voltage_sel = max1586_v3_get_voltage_sel,
>  	.set_voltage_sel = max1586_v3_set_voltage_sel,
>  	.list_voltage = regulator_list_voltage_linear,
>  	.map_voltage = regulator_map_voltage_linear,
>  };
>  
> -static struct regulator_ops max1586_v6_ops = {
> +static const struct regulator_ops max1586_v6_ops = {
>  	.get_voltage_sel = max1586_v6_get_voltage_sel,
>  	.set_voltage_sel = max1586_v6_set_voltage_sel,
>  	.list_voltage = regulator_list_voltage_table,
>