Re: [PATCH] mm: mark gup_pud_range as unused

From: Kirill A. Shutemov
Date: Mon Mar 13 2017 - 01:22:03 EST


On Mon, Mar 13, 2017 at 04:58:37PM +1300, Chris Packham wrote:
> The last caller to gup_pud_range was removed in commit c2febafc6773
> ("mm: convert generic code to 5-level paging"). Mark it as unused to
> silence a warning from gcc.
>
> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> ---
> I saw this warning when compiling 4.11-rc2 with -Werror. An equally valid fix
> would be to remove the function entirely but I went for the less invasive
> approach.

Thanks for report. But real fix is to call gup_pud_range() from
gup_p4d_range(), not itself.

I'll post a fix.
Reported-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
Reported-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>

--
Kirill A. Shutemov