Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt

[RadosÅaw Pietrzyk]

Understood

2017-03-13 12:19 GMT+01:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
> On Mon, Mar 13, 2017 at 12:16:13PM +0100, RadosÅaw Pietrzyk wrote:
>> Ok I will. I just have thought that in general it might be helpful to
>> have this possibility as DT is parsed for this option anyway. If you
>> think it is not needed at all that why to bother parsing DT for this
>> option in the first place ?
>
> I'm not saying it's a wrong patch, I just think the patch description
> doesn't explain why you are doing it or the user visible effects of the
> change.
>
> regards,
> dan carpenter
>