Re: WTH is going on with memory hotplug sysf interface (was: Re: [RFC PATCH] mm, hotplug: get rid of auto_online_blocks)

From: Reza Arbab
Date: Mon Mar 13 2017 - 10:58:57 EST


On Mon, Mar 13, 2017 at 10:21:45AM +0100, Michal Hocko wrote:
I agree with your general sentiment that this stuff is very nonintuitive.

My criterion for nonintuitive is probably different because I would call this _completely_unusable_. Sorry for being so loud about this but the more I look into this area the more WTF code I see. This has seen close to zero review and seems to be building up more single usecase code on top of previous. We need to change this, seriously!

No argument here. I'm happy to help however I can.

--
Reza Arbab