Re: [PATCH v1 09/10] mm: make rmap_one boolean function

[Andrew Morton]

On Mon, 13 Mar 2017 09:35:52 +0900 Minchan Kim <minchan@xxxxxxxxxx> wrote:

> rmap_one's return value controls whether rmap_work should contine to
> scan other ptes or not so it's target for changing to boolean.
> Return true if the scan should be continued. Otherwise, return false
> to stop the scanning.
> 
> This patch makes rmap_one's return value to boolean.

"SWAP_AGAIN" conveys meaning to the reader, whereas the meaning of
"true" is unclear.  So it would be better to document the return value
of these functions.