Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register

[Jonathan Cameron]

On 13/03/17 13:33, William Breathitt Gray wrote:
> On Sat, Feb 11, 2017 at 09:37:35AM +0000, Jonathan Cameron wrote:
>> On 09/02/17 15:03, William Breathitt Gray wrote:
>>> The flag register is offset by 1 from the respective channel data
>>> register. This patch fixes an off-by-one error when attempting to read a
>>> channel flag register where the base address was not properly offset.
>>>
>>> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
>>> Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx>
>> Applied to the fixes-togreg-post-rc1 branch of iio.git
>> Clue to when this will go upstream is in the name ;)
>>
>> Thanks,
>>
>> Jonathan
> 
> Hi Jonathan,
> 
> I see that this fix made it into 4.11-rc1 but not the 4.10.2 release.
> Is this patch on track to appear in stable, or should I explicitly CC
> stable@xxxxxxxxxxxxxxx to pick this up?
I was half asleep and failed to tag this in the first place.

Send an email to stable@xxxxxxxxxxxxxxx with the commit ID and a request
that it is picked up.  Cc me.

Jonathan
> 
> Thanks,
> 
> William Breathitt Gray
> 
>>> ---
>>>  drivers/iio/counter/104-quad-8.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
>>> index a5913e97945e..f9b8fc9ae13f 100644
>>> --- a/drivers/iio/counter/104-quad-8.c
>>> +++ b/drivers/iio/counter/104-quad-8.c
>>> @@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
>>>  			return IIO_VAL_INT;
>>>  		}
>>>  
>>> -		flags = inb(base_offset);
>>> +		flags = inb(base_offset + 1);
>>>  		borrow = flags & BIT(0);
>>>  		carry = !!(flags & BIT(1));
>>>  
>>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>