Re: [PATCH] usbnet: smsc95xx: Reduce logging noise
From: Guenter Roeck
Date: Mon Mar 13 2017 - 22:13:32 EST
On 03/13/2017 03:32 PM, David Miller wrote:
From: Guenter Roeck <linux@xxxxxxxxxxxx>
Date: Fri, 10 Mar 2017 17:45:21 -0800
An insert/remove stress test generated the following log message sequence.
...
Use netdev_dbg() instead of netdev_warn() for the repeating messages
to reduce logging noise.
Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
The problem I have with changes like this is that outside of your
stress test situation these messages are extremely useful but will
now be hidden making diagnosis of problems more difficult.
In general I agree, but in this case the calling code also generates
another set of error messages, which I considered a bit excessive.
No problem, though, we can live with the noise.
Guenter