Re: [PATCH 1/2] mfd: retu: Add OF device ID table

[Lee Jones]

On Fri, 10 Mar 2017, Javier Martinez Canillas wrote:

> Hello Lee,
> 
> On 02/21/2017 10:34 AM, Javier Martinez Canillas wrote:
> > The driver doesn't have a struct of_device_id table but supported devices
> > are registered via Device Trees. This is working on the assumption that a
> > I2C device registered via OF will always match a legacy I2C device ID and
> > that the MODALIAS reported will always be of the form i2c:<device>.
> > 
> > But this could change in the future so the correct approach is to have a
> > OF device ID table if the devices are registered via OF.
> > 
> > The compatible strings don't have a vendor prefix because that's how it's
> > used currently, and changing this will be a Device Tree ABI break.
> > 
> > Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> > ---
> 
> Any comment on this patch and 2/2?

Apologies, I've been on vacation.

Will get to it in due course.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog