Re: [PATCH v3 2/3] watchdog: s3c2410: Simplify getting driver data

[Guenter Roeck]

On 03/14/2017 06:20 AM, Krzysztof Kozlowski wrote:
> On Tue, Mar 14, 2017 at 3:17 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@xxxxxxxxxxx> wrote:
> > Hi,
> >
> > On Monday, March 13, 2017 09:07:25 PM Krzysztof Kozlowski wrote:
> > > Simplify the flow in helper function for getting the driver data by
> > > using of_device_get_match_data() and only one if() branch.
> > >
> > > The code should be equivalent.
> >
> > While you are at it could you remove s3c2410_get_wdt_drv_data()
> > helper?  It is used only once during probe and is marked inline
> > anyway..
>
> Thanks for feedback!
> The existence of this helper is purely from code readability (thus
> inline does not matter). The probe is big so splitting some small
> self-contained part helps. Not much but a little...

Agreed. I don't see value in removing this helper.

Guenter