Re: [PATCH v2] mmc: meson-gx: remove mmc host on device removal

From: Ulf Hansson
Date: Tue Mar 14 2017 - 12:21:56 EST


On 18 February 2017 at 18:06, MichaÅ Zegan <webczat@xxxxxxxxxxxxx> wrote:
> The mmc host was added in meson_mmc_probe, but never removed in
> meson_mmc_remove.
> Fix that by removing the host before deallocating other resources.
>
> Signed-off-by: MichaÅ Zegan <webczat@xxxxxxxxxxxxx>
> Tested-by: MichaÅ Zegan <webczat@xxxxxxxxxxxxx>

Thanks, applied for next!

Kind regards
Uffe

> ---
> changes since v1:
> rebased on top of patchset at
> https://patchwork.kernel.org/patch/9581057/
> This is in turn based on patchset at
> https://patchwork.kernel.org/patch/9561215/
>
> drivers/mmc/host/meson-gx-mmc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index e759e4c2e4a0..336b6a2e94c6 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
> {
> struct meson_host *host = dev_get_drvdata(&pdev->dev);
>
> + mmc_remove_host(host->mmc);
> +
> /* disable interrupts */
> writel(0, host->regs + SD_EMMC_IRQ_EN);
>
> --
> 2.11.0
>