Re: [PATCH] drm/exynos: Print kernel pointers in a restricted form
From: Krzysztof Kozlowski
Date: Tue Mar 14 2017 - 15:09:13 EST
On Tue, Mar 14, 2017 at 08:01:41PM +0100, Tobias Jakobi wrote:
> Hello Krzysztof,
>
> I was wondering about the benefit of this. From a quick look these are
> all messages that end up in the kernel log / dmesg.
>
> IIRC %pK does nothing there, since dmest_restrict is supposed to be used
> to deny an unpriviliged user the access to the kernel log.
>
> Or am I missing something here?
These are regular printks so depending on kernel options (e.g. dynamic
debug, drm.debug) these might be printed also in the console. Of course
we could argue then if access to one of the consoles is worth
securing.
Actually, I think that we should get rid of printing of these kernel
pointers entirely...
Best regards,
Krzysztof