Re: [OpenRISC] [PATCH 3/3] openrisc: Export symbols needed by modules

[Stafford Horne]

On Tue, Mar 14, 2017 at 04:25:30PM +0100, Geert Uytterhoeven wrote:
> Hi Stafford,
> 
> On Tue, Mar 14, 2017 at 3:56 PM, Stafford Horne <shorne@xxxxxxxxx> wrote:
> > This was detected by allmodconfig, errors reported:
> >
> >  ERROR: "empty_zero_page" [net/ceph/libceph.ko] undefined!
> >  ERROR: "__ucmpdi2" [lib/842/842_decompress.ko] undefined!
> >  ERROR: "empty_zero_page" [fs/nfs/objlayout/objlayoutdriver.ko] undefined!
> >  ERROR: "empty_zero_page" [fs/exofs/exofs.ko] undefined!
> >  ERROR: "empty_zero_page" [fs/crypto/fscrypto.ko] undefined!
> >  ERROR: "__ucmpdi2" [fs/btrfs/btrfs.ko] undefined!
> >  ERROR: "pm_power_off" [drivers/regulator/act8865-regulator.ko] undefined!
> >
> > Signed-off-by: Stafford Horne <shorne@xxxxxxxxx>
> 
> > --- a/arch/openrisc/kernel/or32_ksyms.c
> > +++ b/arch/openrisc/kernel/or32_ksyms.c
> > @@ -42,6 +42,11 @@ DECLARE_EXPORT(__muldi3);
> >  DECLARE_EXPORT(__ashrdi3);
> >  DECLARE_EXPORT(__ashldi3);
> >  DECLARE_EXPORT(__lshrdi3);
> > +DECLARE_EXPORT(__ucmpdi2);
> > +
> > +extern unsigned long empty_zero_page[2048];
> 
> Can't you #include <asm/pgtable.h> instead of adding a forward
> declaration?

Right, I can do this.

In the end I was hoping to convert empty_zero_page to be more like
parisc. which would put something like this mm/init.c

  unsigned long *empty_zero_page __read_mostly;
  EXPORT_SYMBOL(empty_zero_page);

  in init {
    empty_zero_page = get_memblock(PAGE_SIZE);
  }

But I was going to wait until 4.12 for that change.

-Stafford

> > +EXPORT_SYMBOL(empty_zero_page);
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds