Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses

[Steven Rostedt]

On Wed, 15 Mar 2017 14:44:36 +0100
Jiri Slaby <jslaby@xxxxxxx> wrote:

> @@ -16,14 +17,6 @@
>  
>  #ifdef CONFIG_FUNCTION_TRACER
>  
> -#ifdef CC_USING_FENTRY
> -# define function_hook	__fentry__
> -EXPORT_SYMBOL(__fentry__)

There's a reason the export symbols are here.

> -#else
> -# define function_hook	mcount
> -EXPORT_SYMBOL(mcount)
> -#endif
> -
>  /* All cases save the original rbp (8 bytes) */
>  #ifdef CONFIG_FRAME_POINTER
>  # ifdef CC_USING_FENTRY
> @@ -297,6 +290,7 @@ trace:
>  	jmp fgraph_trace
>  END(function_hook)
>  #endif /* CONFIG_DYNAMIC_FTRACE */
> +EXPORT_SYMBOL(function_hook)

Under certain configs, this will fail the build. EXPORT_SYMBOL() does
not take the function_hook as a macro nicely. See commit 5de0a8c0c24033.

-- Steve

>  #endif /* CONFIG_FUNCTION_TRACER */
>  
>  #ifdef CONFIG_FUNCTION_GRAPH_TRACER