Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses

[Steven Rostedt]

On Wed, 15 Mar 2017 16:49:54 +0100
Jiri Slaby <jslaby@xxxxxxx> wrote:

> On 03/15/2017, 04:40 PM, Steven Rostedt wrote:
> >> -#else
> >> -# define function_hook	mcount
> >> -EXPORT_SYMBOL(mcount)
> >> -#endif
> >> -
> >>  /* All cases save the original rbp (8 bytes) */
> >>  #ifdef CONFIG_FRAME_POINTER
> >>  # ifdef CC_USING_FENTRY
> >> @@ -297,6 +290,7 @@ trace:
> >>  	jmp fgraph_trace
> >>  END(function_hook)
> >>  #endif /* CONFIG_DYNAMIC_FTRACE */
> >> +EXPORT_SYMBOL(function_hook)  
> > 
> > Under certain configs, this will fail the build. EXPORT_SYMBOL() does
> > not take the function_hook as a macro nicely. See commit 5de0a8c0c24033.  
> 
> Ok, thanks, forget about it then. I had the patch in my tree since Feb 3
> 2014, so I can finally drop it...
> 
> 

Great, cause I'm currently cleaning up that code too, and this would
cause conflicts ;-)

-- Steve