Re: [PATCH 2/4] ARM: OMAP2+ hwmod: Allow modules to disable HW_AUTO

[Roger Quadros]

Tony,

On 14/03/17 17:48, Tony Lindgren wrote:
> * Roger Quadros <rogerq@xxxxxx> [170313 04:55]:
> 
>> --- a/arch/arm/mach-omap2/omap_hwmod.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod.c
>> @@ -2149,7 +2149,7 @@ static int _idle(struct omap_hwmod *oh)
>>  		_idle_sysc(oh);
>>  	_del_initiator_dep(oh, mpu_oh);
>>  
>> -	if (oh->clkdm)
>> +	if (oh->clkdm && !(oh->flags & HWMOD_CLKDM_NOAUTO))
>>  		clkdm_deny_idle(oh->clkdm);
>>  
>>  	if (oh->flags & HWMOD_BLOCK_WFI)
> 
> Is this change to _idle() really needed? It seems that the
> clkdm_deny_idle() there is paired with the clkdm_allow_idle()
> later on in the same function?
> 

You are right. This change to _idle() is unnecessary. I'll send an update.

-- 
cheers,
-roger