Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c
From: Arnd Bergmann
Date: Thu Mar 16 2017 - 06:12:19 EST
On Thu, Mar 16, 2017 at 10:55 AM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> Arnd Bergmann <arnd@xxxxxxxx> writes:
>> On Wed, Mar 15, 2017 at 6:35 AM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
>>> I'll do patches for everything above that's not drivers/soc or
>>> include/soc and hopefully we can hear from someone at NXP on the plans
>>> for getting the soc parts enabled on arm.
>>
>> I think the removal of the NO_IRQ references is a requirement for
>> getting the drivers working properly on ARM, as the OF platform
>> code will use '0' for invalid IRQs.
>
> OK. So the #define NO_IRQ (-1) in arch/arm/include/asm/irq.h is a red
> herring and should be ignored for anything modern?
Correct. There are a couple of older (non-DT) platforms that still rely on it,
and I also have patches for those, which I intend to revisit at some point.
Arnd