Re: [RESEND PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel entry to OF device ID table

From: Dmitry Torokhov
Date: Thu Mar 16 2017 - 14:41:15 EST


On Thu, Mar 16, 2017 at 11:38 AM, Javier Martinez Canillas
<javier@xxxxxxxxxxxxxxx> wrote:
> Hello Dmitry,
>
> On 03/16/2017 03:25 PM, Dmitry Torokhov wrote:
>> On Fri, Mar 10, 2017 at 10:22 AM, Dmitry Torokhov
>> <dmitry.torokhov@xxxxxxxxx> wrote:
>>>
>>> On Fri, Mar 10, 2017 at 10:33:06AM -0300, Javier Martinez Canillas wrote:
>>>> The OF device ID table doesn't have a sentinel NULL entry and so it
>>>> causes the following error:
>>>>
>>>> FATAL: drivers/auxdisplay/img-ascii-lcd: struct of_device_id is not terminated with a NULL entry!
>>>> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
>>>> make[1]: *** [__modpost] Error 1
>>>> Makefile:1493: recipe for target 'modules' failed
>>>> make: *** [modules] Error 2
>>>>
>>>> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>>>
>>> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>>>
>>> This was also causing issues with 0-day builder when driver is built
>>> into the kernel.
>>
>> It looks like Greg KH picked my version of this patch...
>>
>
> Great, glad that your version was picked since it seems these two patches
> were never going to make it.

How about you try sending the 2nd patch to him as well since he seems
to be picking up auxdisplay changes?

--
Dmitry