Re: [PATCH v2 05/23] MAINTAINERS: Add file patterns for dove device tree bindings

[Geert Uytterhoeven]

Hi Jason,

On Mon, Mar 13, 2017 at 2:01 PM, Jason Cooper <jason@xxxxxxxxxxxxxx> wrote:
> On Sun, Mar 12, 2017 at 02:16:49PM +0100, Geert Uytterhoeven wrote:
>> Submitters of device tree binding documentation may forget to CC
>> the subsystem maintainer if this is missing.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>> Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
>> Cc: Andrew Lunn <andrew@xxxxxxx>
>> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
>> Cc: Gregory Clement <gregory.clement@xxxxxxxxxxxxxxxxxx>
>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> ---
>> Please apply this patch directly if you want to be involved in device
>> tree binding documentation for your subsystem.
>>
>> v2:
>>   - No changes.
>>
>> Impact on next-20170310:
>>
>> +Jason Cooper <jason@xxxxxxxxxxxxxx> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
>> +Andrew Lunn <andrew@xxxxxxx> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
>> +Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
>> +Gregory Clement <gregory.clement@xxxxxxxxxxxxxxxxxx> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
>>  Rob Herring <robh+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  Mark Rutland <mark.rutland@xxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>> +linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated list:ARM/Marvell Dove/MV78xx0/Orion SOC support)
>>  devicetree@xxxxxxxxxxxxxxx (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  linux-kernel@xxxxxxxxxxxxxxx (open list)
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 6428d3c82fce9670..ce461fefec6c9463 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1486,6 +1486,7 @@ M:      Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
>>  M:   Gregory Clement <gregory.clement@xxxxxxxxxxxxxxxxxx>
>>  L:   linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
>>  S:   Maintained
>> +F:   Documentation/devicetree/bindings/soc/dove/
>
> I'm not opposed to the idea, but I'm not seeing how we can do this
> completely.  What you've added only covers dove soc bindings.  There's
> orion5x, kirkwood, and all the newer mvebu socs.  Not to mention a lot
> of IP blocks we care about that aren't SoC- or Marvell-specific.

There's no orion5x, kirkwood, mvebu, ... under
Documentation/devicetree/bindings/soc.

> The dts files have a much more clear file pattern -> maintainer pairing.
> Perhaps we should make checkpatch smarter?  e.g. compatible strings
> found in changed binding docs are searched for in dts{i} files.  Hits
> are mapped to maintainers.

The DTS files are maintained by a platform maintainer, while my patch
series was about Linux kernel subsystem maintainers.

In this particular case both maintainers are the same, but this is not true in
general.  Hence deriving a platform maintainer from a Linux subsystem specific
binding document is the wrong way around.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds