Re: [PATCH 0/5] mm subsystem refcounter conversions

[Herbert Xu]

Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> The performance implications of this proposal are terrifying.
> 
> I suggest adding a set of non-debug inlined refcount functions which
> just fall back to the simple atomic.h operations.
> 
> And add a new CONFIG_DEBUG_REFCOUNT.  So the performance (and code
> size!) with CONFIG_DEBUG_REFCOUNT=n is unaltered from present code. 
> And make CONFIG_DEBUG_REFCOUNT suitably difficult to set.

I agree.  Refcounts are used in many performance-critical sites
within the network subsystem.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt