Re: [PATCH v2 16/17] iio: accel: mma7660: Add OF device ID table

[Jonathan Cameron]

On 15/03/17 04:45, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
> 
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
> 
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
Applied.
> ---
> 
>  drivers/iio/accel/mma7660.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/iio/accel/mma7660.c b/drivers/iio/accel/mma7660.c
> index 3a40774cca74..42fa57e41bdd 100644
> --- a/drivers/iio/accel/mma7660.c
> +++ b/drivers/iio/accel/mma7660.c
> @@ -253,6 +253,12 @@ static const struct i2c_device_id mma7660_i2c_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, mma7660_i2c_id);
>  
> +static const struct of_device_id mma7660_of_match[] = {
> +	{ .compatible = "fsl,mma7660" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, mma7660_of_match);
> +
>  static const struct acpi_device_id mma7660_acpi_id[] = {
>  	{"MMA7660", 0},
>  	{}
> @@ -264,6 +270,7 @@ static struct i2c_driver mma7660_driver = {
>  	.driver = {
>  		.name = "mma7660",
>  		.pm = MMA7660_PM_OPS,
> +		.of_match_table = mma7660_of_match,
>  		.acpi_match_table = ACPI_PTR(mma7660_acpi_id),
>  	},
>  	.probe		= mma7660_probe,
>