Re: [PATCH v2 10/17] iio: light: apds9960: Add OF device ID table

[Jonathan Cameron]

On 15/03/17 04:44, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
> 
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
> 
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
Applied.
> ---
> 
>  drivers/iio/light/apds9960.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> index a4304edc3e0f..90bc98df362b 100644
> --- a/drivers/iio/light/apds9960.c
> +++ b/drivers/iio/light/apds9960.c
> @@ -1122,9 +1122,16 @@ static const struct i2c_device_id apds9960_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, apds9960_id);
>  
> +static const struct of_device_id apds9960_of_match[] = {
> +	{ .compatible = "avago,apds9960" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, apds9960_of_match);
> +
>  static struct i2c_driver apds9960_driver = {
>  	.driver = {
>  		.name	= APDS9960_DRV_NAME,
> +		.of_match_table = apds9960_of_match,
>  		.pm	= &apds9960_pm_ops,
>  	},
>  	.probe		= apds9960_probe,
>