Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

[Mark Brown]

On Mon, Mar 20, 2017 at 03:46:13PM +0000, Kai-Heng Feng wrote:
> On Mon, Mar 20, 2017 at 11:08 PM Mark Brown <broonie@xxxxxxxxxx> wrote:

> > As covered in SubmittingPatches this should come after the ---, it
> > doesn't need to end up in the changelogs.

> Do you mean
> https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L197
>  ?
> I didn't find any hard rules regarding this, but I'll keep it in mind.

As it says there "...and inserted automatically following the three dash
line".

> > > SND_SOC_DAPM_POST_PMD: +     case SND_SOC_DAPM_POST_PMU: +
> > > snd_soc_write(codec, RT286_SET_AMP_GAIN_HPO, AMP_OUT_MUTE); +
> > > break; +     case SND_SOC_DAPM_PRE_PMU:

Please fix your mail client not to completely mangle quoted patches when
replying.

> > To repeat what I said last time:

> > | After power up we mute the amplifier?  That's worthy of a
> > comment...

> IIUC, HPO Power's  _POST_PMU is triggered right before power down
> (_PRE_PMD), hence it's pretty logical to mute the amplifier at this
> stage.  I can't quite see anything wrong here.

No, that is not the case - I'm not sure what would lead you to believe
that it is.  _POST_PMU is triggered as the last step of powering up the
widget as the name might suggest.  Has this code been tested at all?

> So no I didn't ignore your comment, I simply misinterpreted what you
> meant.  Because of the logical assumption, I thought you were talking
> the unmute part in _PRE_PMU, which I did add in the changelog.

You didn't reply to my review comment and you sent the same code again.
That looks an awful lot like being ignored.

Attachment: signature.asc
Description: PGP signature