Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

[Thomas Gleixner]

On Tue, 21 Mar 2017, Steven Rostedt wrote:
> >  	/*
> >  	 * Disable interrupts so we don't get the IRQ line bouncing
> 
> I'm nervous about the above comment, which in full is:
> 
> 	/*
> 	 * Disable interrupts so we don't get the IRQ line bouncing
> 	 * up and down while interrupts are disabled.
> 	 */
> 
> I'm not sure if disabling interrupts helps on an SMP system. This patch
> does change what happens when port->sysrq is set. But I'm not sure we
> care.

It disables interrupts at the device level which obviously helps whether on
SMP or not.

Thanks,

	tglx