Re: [PATCH 0/3] dtc updates for 4.12
From: Rob Herring
Date: Tue Mar 21 2017 - 16:05:58 EST
On Tue, Mar 21, 2017 at 2:15 PM, Olof Johansson <olof@xxxxxxxxx> wrote:
> On Tue, Mar 21, 2017 at 9:19 AM, Rob Herring <robh@xxxxxxxxxx> wrote:
>> This series syncs dtc with current mainline. The primary motivation is
>> to pull in the new checks I've worked on. This gives lots of new
>> warnings which are turned off by default.
>>
>> Arm-soc folks, I've left the PCI checks enabled as they are pretty much
>> all real errors and there aren't that many (about 1200, but that's lots
>> of duplicates). I have a patch for some of them.
>
> Yay for better warnings!
>
> But as with all changes of this kind, when new warnings are introduced
> please give people some time to remove them without turning them on by
> default. We had a cycle like that already.
Which I quickly fixed and learned my lesson. That's why I tried
getting this out earlier as well.
> Main reason is that it becomes too hard to spot new warnings when they
> come in if the logs are flooded with 1200 existing warnings.
Yeah. Since almost everything is an include, the warnings really multiply.
> How many of them do you have patches for, per chance? If we can see
> them show up quickly the answer to the above might be a bit different.
Okay, I lied or lost them... It looks like it is 79 unique warnings
for arm. I'll take a stab at fixing them.
Rob