Re: [PATCHv3] x86/mm: set x32 syscall bit in SET_PERSONALITY()

From: Thomas Gleixner
Date: Tue Mar 21 2017 - 18:35:19 EST


On Tue, 21 Mar 2017, hpa@xxxxxxxxx wrote:

> On March 21, 2017 3:21:13 PM PDT, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> >On Tue, 21 Mar 2017, Dmitry Safonov wrote:
> >> v3:
> >> - clear x32 syscall flag during x32 -> x86-64 exec() (thanks, HPA).
> >
> >For correctness sake, this wants to be cleared in the IA32 path as
> >well. It's not causing any harm, but ....
> >
> >I'll amend the patch.
> >
> >Thanks,
> >
> > tglx
>
> Since the i386 syscall namespace is totally separate (and different),
> should we simply change the system call number to the appropriate
> sys_execve number?

That should work as well and would be more intuitive.

Thanks,

tglx