Re: [PATCH 6/6 v3] ftrace/x86: Use Makefile logic instead of #ifdef of compling ftrace_*.o

[Steven Rostedt]

On Mon, 20 Mar 2017 09:04:25 -0500
Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:

> On Sat, Mar 18, 2017 at 05:09:29PM -0400, Steven Rostedt wrote:
> > From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>
> > 
> > Currently ftrace_32.S and ftrace_64.S are compiled even when
> > CONFIG_FUNCTION_TRACER is not set. This means there's an
> > unnecessary #ifdef to protect the code. Instead of using
> > preprocessor directives, only compile those files when
> > FUNCTION_TRACER is defined.
> > 
> > Link:
> > 20170316210043.peycxdxktwwn6cid@treble">http://lkml.kernel.org/r/20170316210043.peycxdxktwwn6cid@treble
> > Suggested-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx> Signed-off-by:
> > Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>  
> 
> The subject has a typo ("compling") and would parse better if the
> second "of" where changed to a "for": "for compiling".  Otherwise:

But this was to comply with #ifdef of ftrace_*.o!

;-)

> 
> Reviewed-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> 

Thanks!

-- Steve