Re: [PATCH] drm/msm/hdmi: redefinitions of macros not required

[Vinay Simha B N]

hi,

Could you please give some feedback or review comments for this patch

On 3/14/17, Vinay Simha BN <simhavcs@xxxxxxxxx> wrote:
> 4 macros already defined in hdmi.h,
> which is not required to redefine in hdmi_audio.c
>
> Signed-off-by: Vinay Simha BN <simhavcs@xxxxxxxxx>
> ---
>  drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> index a54d3bb..8177e85 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> @@ -18,13 +18,6 @@
>  #include <linux/hdmi.h>
>  #include "hdmi.h"
>
> -
> -/* Supported HDMI Audio channels */
> -#define MSM_HDMI_AUDIO_CHANNEL_2		0
> -#define MSM_HDMI_AUDIO_CHANNEL_4		1
> -#define MSM_HDMI_AUDIO_CHANNEL_6		2
> -#define MSM_HDMI_AUDIO_CHANNEL_8		3
> -
>  /* maps MSM_HDMI_AUDIO_CHANNEL_n consts used by audio driver to # of
> channels: */
>  static int nchannels[] = { 2, 4, 6, 8 };
>
> --
> 2.7.4
>
>


-- 
regards,
vinaysimha