Re: [PATCH v2 6/6] selftests: enable O and KBUILD_OUTPUT
From: Bamvor Zhang Jian
Date: Wed Mar 22 2017 - 08:52:45 EST
Hi, Michael, Shuah
On 22 March 2017 at 12:38, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> Bamvor Zhang Jian <bamvor.zhangjian@xxxxxxxxxx> writes:
>> On 21 March 2017 at 16:35, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
>>> I see at least 18 Makefile's in tools/testing/selftests that use
>>> $(OUTPUT)/, which would all need to be updated at least to use $(OUTPUT)
>>> (no trailing slash), and then some other changes to not propagate OUTPUT
>>> when the user didn't specify it. But hopefully someone will prove me
>>> wrong.
>> I also look at this issue. Originally, I use OUTPUT without slash in my
>> patch. People argue that it is not very clear. So, I add slash in curent
>> version.
>
> That was me, you can say so.
>
> I wasn't thinking at the time of OUTPUT being empty, but with hindsight
> obviously I should have.
After think about it. I find a way to keep OUTPUT with out slash. Could
you please take a look?
I have already test the x86 with the following method:
make -C tools/testing/selftests TAREGTS=x86
make -C tools/testing/selftests/x86
make -C tools/testing/selftests/x86 xxx
The build flag and dependency is correct.
Build all the testcase succesful. I am running the test and try difference build
method. Hope I could solve the regression soon.
Regards
Bamvor