Re: [PATCH 2/5] mfd: intel_soc_pmic: Select designware i2c-bus driver

[Andy Shevchenko]

On Wed, 2017-03-22 at 12:29 +0100, Hans de Goede wrote:
> The Crystal Cove PMIC provides an ACPI OPRegion handler, which must be
> available before other drivers using it are loaded, which is why
> INTEL_SOC_PMIC is a bool.
> 
> Just having the driver is not enough, the driver for the i2c-bus must
> also be built in, to ensure this, this patch adds a select for it.
> 

> While at it this patch also changes the human readable name of the
> Kconfig
> option to make clear the INTEL_SOC_PMIC option selects support for the
> Intel Crystal Cove PMIC and documents why this is a bool.

The above is what my patch does, I'm okay if the change is going with
this series as long as Lee is on the same side.ÂOtherwise I would prefer
to go my changes first.

> 
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
> Note this patch will partially conflicts with (contains the same
> changes as)
> a patch in Andy Shevchenko's tree.
> ---
> Âdrivers/mfd/Kconfig | 7 +++++--
> Â1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index d427a10..0c6a967 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -425,14 +425,17 @@ config LPC_SCH
> Â	ÂÂSystem Management Bus and General Purpose I/O.
> Â
> Âconfig INTEL_SOC_PMIC
> -	bool "Support for Intel Atom SoC PMIC"
> +	# This is a bool as it provides an ACPI Opregion which must
> be
> +	# available as soon as possible
> +	bool "Support for Intel Crystal Cove PMIC"
> Â	depends on GPIOLIB
> Â	depends on I2C=y
> Â	select MFD_CORE
> Â	select REGMAP_I2C
> Â	select REGMAP_IRQ
> +	select I2C_DESIGNWARE_PLATFORM
> Â	help
> -	ÂÂSelect this option to enable support for the PMIC device
> +	ÂÂSelect this option to enable support for the Crystal Cove
> PMIC
> Â	ÂÂon some Intel SoC systems. The PMIC provides ADC, GPIO,
> Â	ÂÂthermal, charger and related power management functions
> Â	ÂÂon these systems.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy