Re: [PATCH v1 3/5] ARM: dts: stm32ap: Add watchdog support for STM32F429 SoC

[Alexandre Torgue]

Hi

On 03/22/2017 02:36 PM, Yannick Fertre wrote:
> Signed-off-by: Yannick FERTRE <yannick.fertre@xxxxxx>
> ---

Please add a commit message, and change commit header as following:

ARM: dts: stm32: ...

>  arch/arm/boot/dts/stm32f429.dtsi | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
> index ee0da97..148273b 100644
> --- a/arch/arm/boot/dts/stm32f429.dtsi
> +++ b/arch/arm/boot/dts/stm32f429.dtsi
> @@ -65,7 +65,7 @@
>  			clock-frequency = <32768>;
>  		};
>
> -		clk-lsi {
> +		clk_lsi: clk-lsi {
>  			#clock-cells = <0>;
>  			compatible = "fixed-clock";
>  			clock-frequency = <32000>;
> @@ -812,6 +812,13 @@
>  			clocks = <&rcc 0 STM32F4_AHB2_CLOCK(RNG)>;
>
>  		};
> +
> +		iwdg: iwdg@40003000 {
Please try to keep nodes ordered.

> +			compatible = "st,stm32-iwdg";
> +			reg = <0x40003000 0x400>;
> +			clocks = <&clk_lsi>;
> +			status = "disabled";
> +		};
>  	};
>  };