Re: [PATCH] ARM: dts: rockchip: setup DMA-channels for mmc0 and emmc for rk3188

[Alexander Kochetkov]

Hello, Heiko!

> 22 ÐÐÑÑÐ 2017 Ð., Ð 18:54, Heiko Stuebner <heiko@xxxxxxxxx> ÐÐÐÐÑÐÐ(Ð):
> 
> I've applied a slightly different variant in [0] with your commit message and
> moved the dma properties to the mmc/emmc nodes in rk3xxx.dtsi - as the dma
> channels are the same on both rk3188 and rk3066.

Thank you! I had changes in the rk3xxx.dtsi initially, but them moved them
into rk3188. Donât know why I did that. May be because I donât have rk3066
based board to test on.

> While at it, I've also added the sdio dma as there is no need to leave it out.

Iâve tested mmc0 and emm and they work great. I havenât tested sdio.

> 
> Also when changing the devicetree, please do not append stuff at the bottom
> but instead sort new nodes (the &mmc &emmc in this case) and properties
> alphabetically.

Ok. Thank you.

I have working settings for eMMC for radxa rock. What do you think, is it good idea to add them
to the kernel DT? As Radxa Rock doesnât come with eMMC, but eMMC can be soldered manually.

Alexander.