Re: [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver

[Sergei Shtylyov]

Hello!

On 03/22/2017 08:49 PM, Bartlomiej Zolnierkiewicz wrote:

> > > Add Palmchip BK3710 PATA controller driver.
> > >
> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> >
> > There are some checkpatch suggestions that are worth fixing, I think.
> >
> > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> - 2017-03-14 2206.eml:277: CHECK: Alignment should match open parenthesis
> > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> - 2017-03-14 2206.eml:320: CHECK: Alignment should match open parenthesis
> > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> - 2017-03-14 2206.eml:489: CHECK: Comparison to NULL could be written "!mem"
>
> Will be fixed in v3, thanks.
>
> [ My scripts didn't run checkpatch with --strict so I haven't noticed them. ]

  --strict'ly speaking, this switch is only forced on in the networking 
trees. :-)

> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics

MBR, Sergei