Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

[Grygorii Strashko]

On 03/22/2017 01:01 PM, Steven Rostedt wrote:
> On Wed, 22 Mar 2017 12:37:59 -0500
> Julia Cartwright <julia@xxxxxx> wrote:
>
> > Which kernel were you testing on, here?  From what I can tell, this
> > should have been fixed with Thomas's commit:
> >
> >    2a1d3ab8986d ("genirq: Handle force threading of irqs with primary
> > and thread handler")
>
> Thanks Julia for looking into this. I just looked at the code, and saw
> that it does very little with the lock held, and was fine with the
> conversion. But if that interrupt handler should be in a thread, we
> should see if that's the issue first.


It will not be threaded because there are IRQF_ONESHOT used.

	ret = devm_request_threaded_irq(&pdev->dev, irq,
					sti_mbox_irq_handler,
					sti_mbox_thread_handler,
					IRQF_ONESHOT, mdev->name, mdev);

> > Which landed in 4.4.  It forces the primary handler to be threaded as
> > well.
>
> Lionel,
>
> Can you check if this is an issue with 4.4 too?


--
regards,
-grygorii