Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector
From: Luck, Tony
Date: Wed Mar 22 2017 - 15:00:39 EST
On Thu, Mar 09, 2017 at 11:08:17AM +0100, Borislav Petkov wrote:
> +static bool cec_add_mce(struct mce *m)
> +{
> + if (!m)
> + return false;
> +
> + if (memory_error(m) && mce_usable_address(m))
> + if (!cec_add_elem(m->addr >> PAGE_SHIFT))
> + return true;
> +
> + return false;
> +}
You also need to check that bit 61 of m->status is zero here.
The collector is hiding uncorrected errors too.
-Tony