Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies

[Sebastian Reichel]

Hi,

On Wed, Mar 22, 2017 at 08:57:16AM -0700, Tony Lindgren wrote:
> * Pavel Machek <pavel@xxxxxx> [170322 02:29]:
> > On Wed 2017-03-22 01:09:11, Sebastian Reichel wrote:
> > > This fixes compilation for files, that try to include the
> > > cpcap header in alphabetically sorted #include lists.
> > > 
> > > Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx>
> > 
> > Acked-by: Pavel Machek <pavel@xxxxxx>
> 
> Hmm I wonder why I never ran into this so far. No objections
> to the patch though if it fixes the issue with all the necessary
> headers included.

Because you usually sort includes differently moving headers
from linux/subdir/XYZ after linux/XYZ. That way regmap.h and
device.h will already be included when the compiler includes
motorola-cpcap.h.

-- Sebastian

Attachment: signature.asc
Description: PGP signature