Re: [PATCHv2 2/2] leds: cpcap: new driver

[Sebastian Reichel]

Hi Jacek,

On Wed, Mar 22, 2017 at 09:24:35PM +0100, Jacek Anaszewski wrote:
> > +#define CPCAP_LED_OFF 0x0000
> > +#define CPCAP_LED_ON 0x01
> 
> In this case you can do very well without CPCAP_LED_OFF and
> CPCAP_LED_ON, since we have both counterparts in the core:
> LED_OFF and LED_ON.

I will use them in PATCHv3.

> > +static const struct of_device_id cpcap_led_of_match[] = {
> > +	{ .compatible = "motorola,cpcap-led-red", .data = &cpcap_led_red },
> 
> checkpatch.pl complains here:
> 
> WARNING: DT compatible string vendor "motorola" appears un-documented
> 
> Are you adding vendor prefix in some other patch?

Yes, the vendor prefix is added in rtc-next [0].

Since it's just a checkpatch warning and fixed in linux-next I
suggest to ignore it instead of bothering with an immutable branch.

[0] https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=0522de00929e9e9ee51235fc40035179e4d45381

-- Sebastian

Attachment: signature.asc
Description: PGP signature