Re: [PATCH] hibernation: on 32-bit x86, disabled in favor of KASLR

From: Rafael J. Wysocki
Date: Wed Mar 22 2017 - 21:10:43 EST


On Thu, Mar 23, 2017 at 1:27 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> This is a modified revert of commit 65fe935dd238 ("x86/KASLR, x86/power:
> Remove x86 hibernation restrictions"), since it appears that 32-bit
> hibernation still can't support KASLR. 64-bit is fine. Since people have
> been running with KASLR by default on 32-bit since v4.8, this disables
> hibernation (with a warning). Booting with "nokaslr" will disable KASLR
> and enable hibernation.
>
> Reported-by: Evgenii Shatokhin <eugene.shatokhin@xxxxxxxxx>
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # v4.8+

LGTM

Thanks,
Rafael