Re: [EXT] Re: [PATCH v6 07/14] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

[Ziji Hu]

Hi Ulf,

On 2017/3/15 20:48, Ulf Hansson wrote:
> [...]
> 
>> +
>> +Example:
>> +- For eMMC:
>> +
>> +       sdhci@aa0000 {
>> +               compatible = "marvell,armada-ap806-sdhci";
>> +               reg = <0xaa0000 0x1000>;
>> +               interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>
>> +               clocks = <&emmc_clk>;
>> +               clock-names = "core";
>> +               bus-width = <4>;
>> +               marvell,xenon-phy-slow-mode;
>> +               marvell,xenon-tun-count = <11>;
> 
> There's no vmmc-supply here.
> 
> How do you control power to the eMMC card?
> 

	Sorry for the delayed reply.
	Just confirmed with the engineers.

	It seems that there is a regulator.
	I will ask for a complete node example.

>> +
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +               apm_mmccard: mmccard@0 {
>> +                       compatible = "mmc-card";
>> +                       reg = <0>;
>> +               };
>> +       };
>> +
>> +- For SD/SDIO:
>> +
>> +       sdhci@ab0000 {
>> +               compatible = "marvell,armada-cp110-sdhci";
>> +               reg = <0xab0000 0x1000>;
>> +               interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>
>> +               vqmmc-supply = <&sd_regulator>;
> 
> I guess you know vqmmc is for the I/O voltage.
> 
> Again, how do you power the SD/SDIO card? No vmmc?

	The vmmc-supply regulator does exist according to the engineer.
	I will ask them to provide a complete one.

> 
>> +               clocks = <&sdclk>;
>> +               clock-names = "core";
>> +               bus-width = <4>;
>> +               marvell,xenon-tun-count = <9>;
>> +       };
>> +
>> +- For eMMC with compatible "marvell,armada-3700-sdhci":
>> +
>> +       sdhci@aa0000 {
>> +               compatible = "marvell,armada-3700-sdhci";
>> +               reg = <0xaa0000 0x1000>,
>> +                     <phy_addr 0x4>;
>> +               interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>
>> +               clocks = <&emmcclk>;
>> +               clock-names = "core";
>> +               bus-width = <8>;
>> +               mmc-ddr-1_8v;
>> +               mmc-hs400-1_8v;
> 
> Again, no vmmc?
> 

	The engineer told me the power to eMMC card is fixed on this platform.
	They don't implement a specific regulator for eMMC core power.

>> +
>> +               marvell,pad-type = "fixed-1-8v";
>> +
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +               mmccard: mmccard@0 {
>> +                       compatible = "mmc-card";
>> +                       reg = <0>;
>> +               };
>> +       };
>> +
>> +- For SD/SDIO with compatible "marvell,armada-3700-sdhci":
>> +
>> +       sdhci@ab0000 {
>> +               compatible = "marvell,armada-3700-sdhci";
>> +               reg = <0xab0000 0x1000>,
>> +                     <phy_addr 0x4>;
>> +               interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>
>> +               vqmmc-supply = <&sd_regulator>;
> 
> Again, no vmmc?
> 
	
	It seems that the core power to SD is also fixed.

>> +               clocks = <&sdclk>;
>> +               clock-names = "core";
>> +               bus-width = <4>;
>> +
>> +               marvell,pad-type = "sd";
>> +       };
>> --
>> git-series 0.9.1
> 
> 
> Kind regards
> Uffe
>