Re: [PATCH v2 1/4] pinctrl: rockchip: remove unnecessary locking

From: Linus Walleij
Date: Thu Mar 23 2017 - 05:03:55 EST


On Wed, Mar 15, 2017 at 6:46 PM, John Keeping <john@xxxxxxxxxxxx> wrote:

> regmap_update_bits does its own locking and everything else accessed
> here is a local variable so there is no need to lock around it.
>
> Signed-off-by: John Keeping <john@xxxxxxxxxxxx>
> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
> Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>
> ---
> v2:
> - Also remove locking in rockchip_set_schmitt()

This does not apply on my "devel" branch in the pinctrl tree.

Please rebase on that and resend.

Since I have no patches for rockchip so far I suspect this
is not even based on v4.11-rc1 so pls forward-port.

Yours,
Linus Walleij