Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table

From: Javier Martinez Canillas
Date: Thu Mar 23 2017 - 15:15:08 EST


Hello Dmitry,

On 02/22/2017 11:40 AM, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> The compatible strings don't have a vendor prefix because that's how it's
> used currently, and changing this will be a Device Tree ABI break.
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> ---
>

What's your decision about this patch series?

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America