Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as per required context
From: Greg KH
Date: Fri Mar 24 2017 - 04:44:17 EST
On Fri, Mar 24, 2017 at 02:07:11PM +0530, Pranay Kr. Srivastava wrote:
> speakup_allocate used GFP_ATOMIC for allocations
> even while during initialization due to it's use
> in notifier call.
Is that a problem?
> Pass GFP_ flags as well to speakup_allocate depending
> on the context it is called in.
At init, we should be fine to use GFP_ATOMIC, so is this change really
needed?
thanks,
greg k-h