Re: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node

From: Sergei Shtylyov
Date: Fri Mar 24 2017 - 11:33:05 EST


Hello!

On 03/24/2017 06:22 PM, Jacopo Mondi wrote:

Add pin controller node with 12 gpio controller sub-nodes to
r7s72100 dtsi.

Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
---
arch/arm/boot/dts/r7s72100.dtsi | 80 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 80 insertions(+)

diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index b8aa256..83e8f27 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -180,6 +180,86 @@
};
};

+ pinctrl: pinctrl@fcfe3000 {

I suggest to call it "pin-controller@...", no need to reduce.

[...]

MBR, Sergei