[PATCH 1/2] rcu: use bool value directly

From: Nicholas Mc Guire
Date: Sat Mar 25 2017 - 15:46:39 EST


beenonline is declared bool so no need for an explicit comparison

Signed-off-by: Nicholas Mc Guire <der.herr@xxxxxxx>
---

Found by coccinelle: boolinit.cocci complained about
./kernel/rcu/tree.c:2986:14-29: WARNING: Comparison of bool to 0/1

If the comparison was intended for readability I guess it should be
against "false" not 0 - but it seems common to just use bool values
directly.

Patch was compile-tested with: x86_64_defconfig (implies CONFIG_TREE_RCU=y)
(with some sparse warnings)

Patch is against 4.11-rc3 (localversion-next is next-20170324)

kernel/rcu/tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 712ddce..ab9fbec 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -2983,7 +2983,7 @@ __rcu_process_callbacks(struct rcu_state *rsp)
bool needwake;
struct rcu_data *rdp = raw_cpu_ptr(rsp->rda);

- WARN_ON_ONCE(rdp->beenonline == 0);
+ WARN_ON_ONCE(!rdp->beenonline);

/* Update RCU state based on any recent quiescent states. */
rcu_check_quiescent_state(rsp, rdp);
--
2.1.4