Re: [PATCH v10 07/11] btrfs_tree.h: fix include from userland

[Masahiro Yamada]

Hi Nicolas,


2017-03-14 21:54 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>:
> This patch prepares the uapi export by fixing the following errors:
>
> .../linux/btrfs_tree.h:283:2: error: #error "UUID items require BTRFS_UUID_SIZE == 16!"
>  #error "UUID items require BTRFS_UUID_SIZE == 16!"
>
> .../linux/btrfs_tree.h:390:12: error: âBTRFS_UUID_SIZEâ undeclared here (not in a function)
>   __u8 uuid[BTRFS_UUID_SIZE];
>             ^
> .../linux/btrfs_tree.h:796:16: error: âBTRFS_DEV_STAT_VALUES_MAXâ undeclared here (not in a function)
>   __le64 values[BTRFS_DEV_STAT_VALUES_MAX];
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
> ---
>  include/uapi/linux/btrfs_tree.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/btrfs_tree.h b/include/uapi/linux/btrfs_tree.h
> index 6a261cb52d95..6a754ada59af 100644
> --- a/include/uapi/linux/btrfs_tree.h
> +++ b/include/uapi/linux/btrfs_tree.h
> @@ -2,6 +2,7 @@
>  #define _BTRFS_CTREE_H_
>
>  #include <linux/types.h>
> +#include <linux/btrfs.h>
>

Can you move <linux/types.h> below <linux/btrfs.h>
to sort the includes alphabetically?

This also applies to:

include/uapi/linux/qrtr.h in 06/11
include/uapi/linux/cryptouser.h  in 08/11


-- 
Best Regards
Masahiro Yamada