Re: [PATCH] staging: speakup: fix warning for static declaration
From: Samuel Thibault
Date: Mon Mar 27 2017 - 03:59:33 EST
Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote:
> Thanks for this :) Could you also move the function higher in the same
> file - above line 139 where all static functions are defined?
I'd say no need for this. spk_serial_in is just above. Moving functions
just for the sake of static vs non-static does not make the code more
readable to my eyes :)
(and it makes tracking changes harder in git annotate)
Samuel