Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder

[Willy TARREAU]

On Fri, Mar 24, 2017 at 04:19:43PM +0100, Geert Uytterhoeven wrote:
> Hi Andy,
> 
> On Fri, Mar 24, 2017 at 3:29 PM, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Fri, 2017-03-24 at 15:19 +0100, Geert Uytterhoeven wrote:
> >> On Fri, Mar 24, 2017 at 3:06 PM, Andy Shevchenko
> >> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >> > It looks like panel.c belongs to auxdisplay subsystem.
> >> >
> >> > Move it to drivers/auxdisplay folder.
> >> > No functional changes intended.
> >>
> >> I didn't move it to drivers/auxdisplay/ because it not only provides
> >> auxdisplay functionality, but also keypad functionality.
> >
> > Yes, I have noticed this. But keypad functionality is optional while
> > panel is main one. I think you would agree on this.
> 
> I don't care that much, though. Willy?

Well, as long as it continues to work, I don't really care either. The
only thing to keep in mind is that it can be difficult to split the
driver in two since in some cases it's possible to use the same lines
for keypad and lcd.

Willy