Re: [PATCH 2/6] hpet: remove unused writeq/readq function definitions

From: Corentin Labbe
Date: Mon Mar 27 2017 - 04:56:02 EST


On Mon, Mar 27, 2017 at 09:51:23AM +0200, Clemens Ladisch wrote:
> Corentin Labbe wrote:
> > On Mon, Mar 27, 2017 at 07:49:34AM +0800, kbuild test robot wrote:
> >> drivers//char/hpet.c: In function 'hpet_timer_set_irq':
> >>>> drivers//char/hpet.c:207:7: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]
> >
> > Wrongly believed that x86 and x86_64 shared writeq/readq.
> > Sorry, I will drop this patch
> >
> > Since the writeq/readq redefined is present in lots of other file, perhaps adding it to i386 could be done.
>
> Just use <linux/io-64-nonatomic-lo-hi.h> instead.
>

Thanks, much easier than add writeq/readq to whole x86

Regards