Re: [v3 PATCH 2/4] powernv:smp: Add busy-wait loop as fall back for CPU-Hotplug

[Michael Ellerman]

"Gautham R. Shenoy" <ego@xxxxxxxxxxxxxxxxxx> writes:

> diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c
> index 419edff..f335e0f 100644
> --- a/arch/powerpc/platforms/powernv/idle.c
> +++ b/arch/powerpc/platforms/powernv/idle.c
> @@ -283,8 +283,16 @@ unsigned long pnv_cpu_offline(unsigned int cpu)
>  	} else if ((idle_states & OPAL_PM_SLEEP_ENABLED) ||
>  		   (idle_states & OPAL_PM_SLEEP_ENABLED_ER1)) {
>  		srr1 = power7_sleep();
> -	} else {
> +	} else if (idle_states & OPAL_PM_NAP_ENABLED) {
>  		srr1 = power7_nap(1);
> +	} else {
> +		/* This is the fallback method. We emulate snooze */
> +		while (!generic_check_cpu_restart(cpu)) {

Breaks the SMP=n build :/

arch/powerpc/platforms/powernv/idle.c:299:11: error: implicit declaration of function 'generic_check_cpu_restart' [-Werror=implicit-function-declaration]

cheers